Claude/csv loading postgres migration qvkl4l - #40
Merged
Conversation
- api/config.py: add allow_destructive setting (reads API_ALLOW_DESTRUCTIVE env var, defaults true; set false in prod to block table drops) - api/db.py: bootstrap audit_log table so every DELETE is recorded persistently - api/routers/csv_routes.py: three-layer DELETE guard: 403 gate, schema whitelist via information_schema before DROP, INSERT into audit_log after each delete - tests/test_api_coverage.py: enum constraint violation, NULL in NOT NULL column, unknown target table, re-upload replaces registry, DeleteGateUnit 403 unit test Closes critical bugs: DELETE endpoint unguarded, T&E mode test coverage gaps
The startup instruction said 'run from the api/ directory' with 'uvicorn main:app'. Now that all imports are package-relative, the correct command from the repo root is: python -m uvicorn api.main:app --reload --port 8000 scripts/start-api.ps1 was already correct; only the docstring was stale. Closes #36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.